Docs: Mention TypeScript's compiler check #12903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
eslint-deprecated
bot
added
the
triage
nzakas
approved these changes
Feb 28, 2020
montmanu
pushed a commit
to montmanu/eslint
that referenced
this pull request
Mar 4, 2020
* Docs: Mention TypeScript's compiler check * Update no-dupe-class-members.md
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
I mentioned that TypeScript has the "no-dupe-class-members" rule built in. TypeScript will throw error TS2393 (Duplicate function implementation) if there are problems with the naming. Turning on ESLint's "no-dupe-class-members" rule can lead to false positives because it won't allow function overloading. The "typescript-eslint" project also has that rule turned off.
Is there anything you'd like reviewers to focus on?
Especially the negative impact on using the "no-dupe-class-members" rule with TypeScript should be a reason to highlight that it is safe to turn off the rule when using TypeScript.