Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update eslint:recommended #12911

Closed
nzakas opened this issue Feb 13, 2020 · 1 comment · Fixed by #12920
Closed

Update eslint:recommended #12911

nzakas opened this issue Feb 13, 2020 · 1 comment · Fixed by #12920
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion breaking This change is backwards-incompatible core Relates to ESLint's core APIs and features enhancement This change enhances an existing feature of ESLint
Projects
v7.0.0

Comments

@nzakas
Copy link
Member

nzakas commented Feb 13, 2020

For v7.0.0, we'd like to enable these rules for eslint:recommended:

  • no-import-assign
  • no-dupe-if
  • no-setter-return
@nzakas nzakas added enhancement This change enhances an existing feature of ESLint core Relates to ESLint's core APIs and features accepted There is consensus among the team that this change meets the criteria for inclusion breaking This change is backwards-incompatible labels Feb 13, 2020
@nzakas nzakas added this to Accepted, ready to implement in v7.0.0 Feb 13, 2020
mdjermanovic added a commit that referenced this issue Feb 16, 2020
@mdjermanovic
Breaking: Add new rules to eslint:recommended (fixes #12911)
905376b
@mdjermanovic mdjermanovic mentioned this issue Feb 16, 2020
Merged
2 tasks
@mysticatea mysticatea moved this from Accepted, ready to implement to Issues which have PR in v7.0.0 Feb 16, 2020
v7.0.0 automation moved this from Issues which have PR to Done Feb 25, 2020
nzakas pushed a commit that referenced this issue Feb 25, 2020
@mdjermanovic
Breaking: Add new rules to eslint:recommended (fixes #12911) (#12920)
78182e4
montmanu pushed a commit to montmanu/eslint that referenced this issue Mar 4, 2020
@mdjermanovic @montmanu
Breaking: Add new rules to eslint:recommended (fixes eslint#12911) (e…
bdc7c9f 
…slint#12920)
@edg2s
Copy link
Contributor

edg2s commented Mar 16, 2020

In the issue description, no-dupe-if should be no-dupe-else-if.

@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Aug 25, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Aug 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion breaking This change is backwards-incompatible core Relates to ESLint's core APIs and features enhancement This change enhances an existing feature of ESLint
Projects
No open projects
v7.0.0
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Breaking: Add new rules to eslint:recommended (fixes #12911) eslint/eslint
2 participants
@nzakas @edg2s