Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking: class default true computed-property-spacing (fixes #12812) #12915

Merged
merged 1 commit into from Feb 28, 2020
Merged

Breaking: class default true computed-property-spacing (fixes #12812) #12915

merged 1 commit into from Feb 28, 2020

Conversation

mdjermanovic
Copy link
Member

Prerequisites checklist

  • I have read the contributing guidelines.
  • The team has reached consensus on the changes proposed in this pull request. If not, I understand that the evaluation process will begin with this pull request and won't be merged until the team has reached consensus.

What is the purpose of this pull request? (put an "X" next to an item)

[X] Other, please explain:

fixes #12812

Rule: computed-property-spacing.

This PR changes enforceForClassMembers option's default value to true.

The rule will now by default apply to classes, too.

What changes did you make? (Give an overview)

Changed default value and updated documentation.

Is there anything you'd like reviewers to focus on?

@mdjermanovic mdjermanovic added rule Relates to ESLint's core rules accepted There is consensus among the team that this change meets the criteria for inclusion breaking This change is backwards-incompatible labels Feb 14, 2020
@mysticatea mysticatea added this to Implemented, pending review in v7.0.0 Feb 16, 2020
nzakas
nzakas approved these changes Feb 28, 2020
View reviewed changes
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

kaicataldo
kaicataldo approved these changes Feb 28, 2020
View reviewed changes
Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaicataldo kaicataldo merged commit afa9aac into master Feb 28, 2020
v7.0.0 automation moved this from Implemented, pending review to Done Feb 28, 2020
@kaicataldo kaicataldo deleted the issue12812 branch February 28, 2020 01:17
montmanu pushed a commit to montmanu/eslint that referenced this pull request Mar 4, 2020
@mdjermanovic @montmanu
Breaking: class default true computed-property-spacing (fixes eslin…
1b9cc92 
…t#12812) (eslint#12915)
@mdjermanovic mdjermanovic mentioned this pull request Mar 12, 2020
Closed
2 tasks
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Aug 28, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Aug 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nzakas nzakas nzakas approved these changes

@kaicataldo kaicataldo kaicataldo approved these changes

Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion breaking This change is backwards-incompatible rule Relates to ESLint's core rules
Projects
No open projects
v7.0.0
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change default value for enforceForClassMembers in computed-property-spacing
3 participants
@mdjermanovic @nzakas @kaicataldo