Breaking: Add new rules to eslint:recommended (fixes #12911) #12920
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[X] Add something to the core
fixes #12911
This PR adds the following rules to
eslint:recommended
forv.7.0.0
:no-dupe-else-if
no-import-assign
no-setter-return
What changes did you make? (Give an overview)
Updated the rules and
conf/eslint-recommended.js
Also had to remove dead code found by
no-dupe-else-if
inlib/rules/indent-legacy.js
.Is there anything you'd like reviewers to focus on?
no-dupe-if
in Update eslint:recommended #12911 is a typo?eslint:recommended
should be updated?indent-legacy
.