Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking: Add new rules to eslint:recommended (fixes #12911) #12920

Merged
merged 1 commit into from Feb 25, 2020
Merged

Conversation

mdjermanovic
Copy link
Member

Prerequisites checklist

  • I have read the contributing guidelines.
  • The team has reached consensus on the changes proposed in this pull request. If not, I understand that the evaluation process will begin with this pull request and won't be merged until the team has reached consensus.

What is the purpose of this pull request? (put an "X" next to an item)

[X] Add something to the core

fixes #12911

This PR adds the following rules to eslint:recommended for v.7.0.0:

  • no-dupe-else-if
  • no-import-assign
  • no-setter-return

What changes did you make? (Give an overview)

Updated the rules and conf/eslint-recommended.js

Also had to remove dead code found by no-dupe-else-if in lib/rules/indent-legacy.js.

Is there anything you'd like reviewers to focus on?

@mdjermanovic mdjermanovic added enhancement This change enhances an existing feature of ESLint core Relates to ESLint's core APIs and features accepted There is consensus among the team that this change meets the criteria for inclusion breaking This change is backwards-incompatible labels Feb 16, 2020
Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@mysticatea mysticatea added this to Implemented, pending review in v7.0.0 Feb 16, 2020
Alhadis added a commit to Alhadis/JG that referenced this pull request Feb 24, 2020
@nzakas nzakas merged commit 78182e4 into master Feb 25, 2020
v7.0.0 automation moved this from Implemented, pending review to Done Feb 25, 2020
@nzakas nzakas deleted the issue12911 branch February 25, 2020 00:49
montmanu pushed a commit to montmanu/eslint that referenced this pull request Mar 4, 2020
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Aug 25, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Aug 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion breaking This change is backwards-incompatible core Relates to ESLint's core APIs and features enhancement This change enhances an existing feature of ESLint
Projects
No open projects
v7.0.0
  
Done
Development

Successfully merging this pull request may close these issues.

Update eslint:recommended
3 participants