Update: report rename id destructuring in id-blacklist (fixes #12807)

[yeonjuan]

Prerequisites checklist

• I have read the contributing guidelines.
• The team has reached consensus on the changes proposed in this pull request. If not, I understand that the evaluation process will begin with this pull request and won't be merged until the team has reached consensus.

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

This PR will fix #12807

Is there anything you'd like reviewers to focus on?

It will make a new warning on the below cases. ( about blacklist foo)

1. renaming identifier in an ObjectPattern destructuring.

/*eslint id-blacklist: ["error", "foo"] */

const { bar : foo} = asd;

2. the last identifier in an ObjectPattern destructuring.

/*eslint id-blacklist: ["error", "foo"] */

const { bar : obj.a.a.a.foo} = asd;

[mdjermanovic]

1. renaming identifier in an ObjectPattern destructuring.

This restores correct behavior from v6.8.0.

2. the last identifier in an ObjectPattern destructuring.

These are new warnings.

Maybe we could in another PR add new warnings similar to 2., but when the parent is AssignmentPattern, ArrayPattern or RestElement

[yeonjuan]

@mdjermanovic
Thanks for the review 👍

Maybe we could in another PR add new warnings similar to 2., but when the parent is AssignmentPattern, ArrayPattern or RestElement

I understand that this rule should check when the parent is ArrayPattern or RestElement, so changed it.

But I'm curious why we should check AssignmentPattern in those cases(2.).

foo.data; // all property names that are not assignments are ignored

By the docs at examples of incorrect, it seems this rule should not warn in the below cases(AssignmentPattern).

function foo( baz = obj.bar ) {}; // Should we allow `bar` because it is not assignments? 

Am I missing something?

[mdjermanovic]

I was thinking to cover the remaining cases where obj.bar can be a target in destructuring. In AssignmentPattern it would be when it's left:

({ a: obj.bar = b } = c);
[obj.bar = b] = c;

[kaicataldo]

That seems worthwhile - mind making an issue so we can track it?

[yeonjuan]

@mdjermanovic

({ a: obj.bar = b } = c);
[obj.bar = b] = c;

wow, actually, I've never seen this syntax before. TIL. Thanks :)

@kaicataldo
I don't mind whether resolving it here or making another issue. :)

[mdjermanovic]

LGTM, thanks!

[kaicataldo]

LGTM, thank you!