Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: no-restricted-modules handle TemplateLiteral (fixes #12926) #12927

Merged
merged 3 commits into from Feb 28, 2020
Merged

Update: no-restricted-modules handle TemplateLiteral (fixes #12926) #12927

merged 3 commits into from Feb 28, 2020

Conversation

pieh
Copy link
Contributor

@pieh pieh commented Feb 16, 2020

Prerequisites checklist

  • I have read the contributing guidelines.
  • The team has reached consensus on the changes proposed in this pull request. If not, I understand that the evaluation process will begin with this pull request and won't be merged until the team has reached consensus.

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

Issue: #12926

What changes did you make? (Give an overview)

Added support for TemplateLiteral argument check on top of existing string Literal check to no-restricted-modules rule.

Is there anything you'd like reviewers to focus on?

  • Does this change needs any documentation changes?
  • Are added test fixtures enough?

@jsf-clabot
Copy link

jsf-clabot commented Feb 16, 2020 •
edited

CLA assistant check
All committers have signed the CLA.

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Feb 16, 2020
@pieh pieh changed the title fix: no-restricted-modules handle TemplateLiteral (fixes #12926) Fix: no-restricted-modules handle TemplateLiteral (fixes #12926) Feb 16, 2020
@pieh pieh mentioned this pull request Feb 16, 2020
Closed
@mdjermanovic mdjermanovic linked an issue Feb 16, 2020 that may be closed by this pull request
no-restricted-modules and TemplateLiteral #12926
Closed
@mdjermanovic mdjermanovic added accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly rule Relates to ESLint's core rules and removed triage An ESLint team member will look at this issue soon labels Feb 16, 2020
mdjermanovic
mdjermanovic requested changes Feb 16, 2020
View reviewed changes
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I left a couple of notes.

lib/rules/no-restricted-modules.js Outdated Show resolved Hide resolved
lib/rules/no-restricted-modules.js Outdated Show resolved Hide resolved
@pieh pieh force-pushed the issue12926 branch 2 times, most recently from 10cc836 to 88d5d78 Compare February 16, 2020 23:58
@mdjermanovic
Copy link
Member

Also, the commit message should start with Update: instead of Fix:, because this change produces more warnings.

Alternatively, you can add more commits to this PR so we could just change the PR title.

@pieh pieh changed the title Fix: no-restricted-modules handle TemplateLiteral (fixes #12926) Update: no-restricted-modules handle TemplateLiteral (fixes #12926) Feb 17, 2020
mdjermanovic
mdjermanovic approved these changes Feb 17, 2020
View reviewed changes
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kaicataldo kaicataldo merged commit a5b41a7 into eslint:master Feb 28, 2020
@kaicataldo
Copy link
Member

Thanks for contributing to ESLint!

montmanu pushed a commit to montmanu/eslint that referenced this pull request Mar 4, 2020
@pieh @montmanu
Update: no-restricted-modules handle TemplateLiteral (fixes eslint#12926
f570c48 
) (eslint#12927)

* Update: no-restricted-modules handle TemplateLiteral (fixes eslint#12926)

* add fixture using backslashes

* finally understood, I think
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Aug 28, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Aug 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kaicataldo kaicataldo kaicataldo approved these changes

@mdjermanovic mdjermanovic mdjermanovic approved these changes

Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly rule Relates to ESLint's core rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

no-restricted-modules and TemplateLiteral
4 participants
@pieh @jsf-clabot @mdjermanovic @kaicataldo