Update: Add ESLint API (refs eslint/rfcs#40) #12939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslint-deprecated
bot
added
the
triage
kaicataldo
force-pushed
the
eslint-api
branch
from
ae3b417
to
ff39b5f
Compare
kaicataldo
added
core
kaicataldo
commented
Feb 26, 2020
2 tasks
kaicataldo
force-pushed
the
eslint-api
branch
2 times, most recently
from
d394aa6
to
d7276fd
Compare
|
Closing this for now while I’m out sick, in case someone else can get to it first. |
|
Reopening in case someone wants to work off of this branch (and so it doesn't get removed from the project board). |
Co-Authored-By: Nicholas C. Zakas <nicholas@nczconsulting.com>
Co-Authored-By: Kai Cataldo <kai@kaicataldo.com>
|
Thank you for your review! I applied the suggestions. |
btmills
moved this from Accepted, ready to implement
to Implemented, pending review
in v7.0.0
kaicataldo
commented
Apr 23, 2020
btmills
requested changes
Apr 23, 2020
There was a problem hiding this comment.
Bravo to both @kaicataldo and @mysticatea 👏 This was an enormous lift, and I'm excited to be able to use the new API. I had some suggestions, mostly around the documentation.
Co-Authored-By: Brandon Mills <btmills@users.noreply.github.com>
Co-Authored-By: Brandon Mills <btmills@users.noreply.github.com>
Co-Authored-By: Brandon Mills <btmills@users.noreply.github.com>
Co-Authored-By: Brandon Mills <btmills@users.noreply.github.com>
Co-Authored-By: Brandon Mills <btmills@users.noreply.github.com>
Co-Authored-By: Brandon Mills <btmills@users.noreply.github.com>
Co-Authored-By: Brandon Mills <btmills@users.noreply.github.com>
Co-Authored-By: Brandon Mills <btmills@users.noreply.github.com>
Co-Authored-By: Brandon Mills <btmills@users.noreply.github.com>
Co-Authored-By: Brandon Mills <btmills@users.noreply.github.com>
|
Thank you for your review! I applied suggestions to this PR. |
btmills
approved these changes
Apr 24, 2020
|
@mysticatea Thank you again for picking this up while I was sick ❤️ |
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[x] Add something to the core
[ ] Other, please explain:
refs eslint/rfcs#40
This is a WIP. I received some initial feedback here and have incorporated that into this PR.
What changes did you make? (Give an overview)
This PR adds the new
ESLintclass, which is an asynchronous wrapper around theCLIEngineclass.Is there anything you'd like reviewers to focus on?
Still a WIP, but as I get closer to completion: are the options/type defs correct?