Updated arrow-parens for minor grammar issue #12962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
eslint-deprecated
bot
added
the
triage
yeonjuan
added
documentation
yeonjuan
suggested changes
Feb 25, 2020
There was a problem hiding this comment.
@whynotavailable
Thanks for contributing! 👍
Would you mind adding the commit message tag (Docs:)?
You can find detail information about pull request guidelines here
whynotavailable
force-pushed
the
arrow-parens-one-of-the
branch
from
1bce758
to
b4c389b
Compare
|
@yeonjuan I amended the message to conform to the guidelines. |
kaicataldo
approved these changes
Feb 25, 2020
nzakas
approved these changes
Feb 28, 2020
montmanu
pushed a commit
to montmanu/eslint
that referenced
this pull request
Mar 4, 2020
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
I made a minor grammar change to the docs for arrow-parens. Another way to say it could also be
I prefer what's in the PR as it notes there are multiple benefits to the option more clearly.
Is there anything you'd like reviewers to focus on?
Not particularly.