Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Fix links to custom parsers doc #12965

Merged
merged 1 commit into from Feb 27, 2020
Merged

Docs: Fix links to custom parsers doc #12965

merged 1 commit into from Feb 27, 2020

Conversation

btmills
Copy link
Member

@btmills btmills commented Feb 26, 2020

Prerequisites checklist

  • I have read the contributing guidelines.
  • The team has reached consensus on the changes proposed in this pull request. If not, I understand that the evaluation process will begin with this pull request and won't be merged until the team has reached consensus.

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

The documentation for custom parsers was extracted from the main
"Working with Plugins" documentationn to its own page in #10431.

Is there anything you'd like reviewers to focus on?

I grepped the documentation to make sure I found all of the links:

$ grep -r 'working-with-custom-parsers' docs
docs/user-guide/configuring.md:1. It must conform to the [parser interface](/docs/developer-guide/working-with-custom-parsers.md).
docs/developer-guide/README.md:## Section 6: [Working with Custom Parsers](working-with-custom-parsers.md)
docs/developer-guide/nodejs-api.md:with the name of the parser as first argument and the [parser object](/docs/developer-guide/working-with-custom-parsers.md) as second argument. The default `"espree"` parser will already be loaded for every `Linter` instance.

The documentation for custom parsers was extracted from the main
"Working with Plugins" documentationn to its own page in #10431.
@btmills btmills added documentation Relates to ESLint's documentation accepted There is consensus among the team that this change meets the criteria for inclusion labels Feb 26, 2020
@btmills btmills merged commit cf14355 into master Feb 27, 2020
@btmills btmills deleted the custom-parsers-links branch February 27, 2020 18:19
montmanu pushed a commit to montmanu/eslint that referenced this pull request Mar 4, 2020
The documentation for custom parsers was extracted from the main
"Working with Plugins" documentation to its own page in eslint#10431.
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Aug 27, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Aug 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants