Chore: update space-before-function-paren in eslint-config-eslint #12966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslint-deprecated
bot
added
the
triage
kaicataldo
added
chore
|
I like that a space is there. |
nzakas
approved these changes
Feb 28, 2020
|
Going to go ahead and merge this since 3/4 TSC members are supportive of this change. |
montmanu
pushed a commit
to montmanu/eslint
that referenced
this pull request
Mar 4, 2020
…lint#12966) * Chore: update space-before-function-paren in eslint-config-eslint * Run autofixer
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:
Updating
eslint-config-eslintWhat changes did you make? (Give an overview)
Working on #12939, I noticed that we currently enforce no spaces between the
asynckeyword and the parens of an async arrow function.This PR updates our
space-before-function-parenconfiguration to require a space in this case (leaving everything else unchanged).Is there anything you'd like reviewers to focus on?
We have a few existing cases of
asyncarrow functions in our codebase, but they're all in our tests. Does this seem desirable to everyone? I personally find it easier to parse visually.