Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: added lock files to gitignore #13015

Merged
merged 1 commit into from Mar 10, 2020

Conversation

anikethsaha
Copy link
Member

Prerequisites checklist

  • I have read the contributing guidelines.
  • The team has reached consensus on the changes proposed in this pull request. If not, I understand that the evaluation process will begin with this pull request and won't be merged until the team has reached consensus.

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[X] Other, please explain:

updating .gitignore

What changes did you make? (Give an overview)

follow-up from here #13004 (comment)
As eslint is not committing lock files , I added them to gitignore for safety as not to get committed in future if not required

Is there anything you'd like reviewers to focus on?

If there is a plan to commit lock files, then this PR needs to be changed

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Mar 7, 2020
@nzakas nzakas added chore This change is not user-facing and removed triage An ESLint team member will look at this issue soon labels Mar 10, 2020
@nzakas
Copy link
Member

nzakas commented Mar 10, 2020

Thanks!

@nzakas nzakas merged commit bc0c02c into eslint:master Mar 10, 2020
anikethsaha added a commit to anikethsaha/eslint that referenced this pull request Mar 11, 2020
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Sep 8, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Sep 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants