Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: clarify variables option in no-use-before-define (fixes #12986) #13017

Merged
merged 6 commits into from Mar 23, 2020
Merged

Docs: clarify variables option in no-use-before-define (fixes #12986) #13017

merged 6 commits into from Mar 23, 2020

Conversation

anikethsaha
Copy link
Member

Prerequisites checklist

  • I have read the contributing guidelines.
  • The team has reached consensus on the changes proposed in this pull request. If not, I understand that the evaluation process will begin with this pull request and won't be merged until the team has reached consensus.

What is the purpose of this pull request? (put an "X" next to an item)

  • Documentation update
  • Bug fix (template)
  • New rule (template)
  • Changes an existing rule (template)
  • Add autofixing to a rule
  • Add a CLI option
  • Add something to the core
  • Other, please explain:

What changes did you make? (Give an overview)

updated docs example for variables option in no-use-before-define rule.
fixes #12986

Is there anything you'd like reviewers to focus on?

#12986

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Mar 7, 2020
@nzakas nzakas added documentation Relates to ESLint's documentation and removed triage An ESLint team member will look at this issue soon labels Mar 10, 2020
mdjermanovic
mdjermanovic requested changes Mar 11, 2020
View reviewed changes
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I left a couple of notes.

docs/rules/no-use-before-define.md Outdated Show resolved Hide resolved
docs/rules/no-use-before-define.md Outdated Show resolved Hide resolved
@mdjermanovic mdjermanovic added accepted There is consensus among the team that this change meets the criteria for inclusion rule Relates to ESLint's core rules labels Mar 12, 2020
mdjermanovic
mdjermanovic requested changes Mar 13, 2020
View reviewed changes
docs/rules/no-use-before-define.md Outdated Show resolved Hide resolved
@anikethsaha anikethsaha changed the title Docs: added fn decl example and details for variables option Docs: added fn decl example and details for variables option ( fixes #12986 ) Mar 17, 2020
@anikethsaha anikethsaha changed the title Docs: added fn decl example and details for variables option ( fixes #12986 ) Docs: added fn decl example and details for variables option (fix #12986) Mar 17, 2020
@anikethsaha anikethsaha changed the title Docs: added fn decl example and details for variables option (fix #12986) Docs: fn decl example and details for variables option (fix #12986) Mar 17, 2020
@anikethsaha anikethsaha reopened this Mar 17, 2020
@anikethsaha anikethsaha changed the title Docs: fn decl example and details for variables option (fix #12986) Docs: example and details for variables option (fix #12986) Mar 17, 2020
@anikethsaha anikethsaha reopened this Mar 17, 2020
@anikethsaha anikethsaha changed the title Docs: example and details for variables option (fix #12986) Docs: added fn decl example and details for variables option Mar 17, 2020
mdjermanovic
mdjermanovic approved these changes Mar 17, 2020
View reviewed changes
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic changed the title Docs: added fn decl example and details for variables option Docs: clarify variables option in no-use-before-define (fixes #12986) Mar 17, 2020
@anikethsaha @kaicataldo
Chore: update default for nofunc no-use-before-define
8aef515 
Co-Authored-By: Kai Cataldo <kai@kaicataldo.com>
kaicataldo
kaicataldo approved these changes Mar 23, 2020
View reviewed changes
Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kaicataldo kaicataldo merged commit 3f7c9bf into eslint:master Mar 23, 2020
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Sep 21, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Sep 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kaicataldo kaicataldo kaicataldo approved these changes

@mdjermanovic mdjermanovic mdjermanovic approved these changes

Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation rule Relates to ESLint's core rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

no-use-before-define needs exception option for arrow function definitions present in common code patterns
4 participants
@anikethsaha @kaicataldo @mdjermanovic @nzakas