Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: camelcase false positive with computed property (fixes #13022) #13023

Merged
merged 1 commit into from Mar 10, 2020
Merged

Fix: camelcase false positive with computed property (fixes #13022) #13023

merged 1 commit into from Mar 10, 2020

Conversation

mdjermanovic
Copy link
Member

@mdjermanovic mdjermanovic commented Mar 10, 2020 •
edited

Prerequisites checklist

  • I have read the contributing guidelines.
  • The team has reached consensus on the changes proposed in this pull request. If not, I understand that the evaluation process will begin with this pull request and won't be merged until the team has reached consensus.

What is the purpose of this pull request? (put an "X" next to an item)

[X] Bug fix

fixes #13022

What changes did you make? (Give an overview)

In the branch for computed pattern properties, the camelcase rule should check for inner underscores only, like in all other branches.

Is there anything you'd like reviewers to focus on?

@mdjermanovic mdjermanovic added bug ESLint is working incorrectly rule Relates to ESLint's core rules accepted There is consensus among the team that this change meets the criteria for inclusion labels Mar 10, 2020
yeonjuan
yeonjuan approved these changes Mar 10, 2020
View reviewed changes
Copy link
Member

@yeonjuan yeonjuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@nzakas nzakas merged commit 0243549 into master Mar 10, 2020
@nzakas nzakas deleted the issue13022 branch March 10, 2020 17:36
anikethsaha pushed a commit to anikethsaha/eslint that referenced this pull request Mar 11, 2020
@mdjermanovic @anikethsaha
Fix: camelcase false positive with computed property (fixes eslint#13022
4bdf9f8 
) (eslint#13023)
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Sep 8, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Sep 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nzakas nzakas nzakas approved these changes

@yeonjuan yeonjuan yeonjuan approved these changes

Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly rule Relates to ESLint's core rules
Projects
None yet
Milestone
No milestone
3 participants
@mdjermanovic @nzakas @yeonjuan