[camelcase] false negative in destructuring with assignment

[yeonjuan]

Tell us about your environment

• ESLint Version: 7.0.0-alpha.2
• Node Version: v11.15.0
• npm Version: 6.7.0

What parser (default, Babel-ESLint, etc.) are you using?

default

Please show your full configuration:

Configuration

What did you do? Please include the actual source code causing the issue, as well as the command that you used to run ESLint.

• Online Demo

/*eslint camelcase: ["error"] */
var obj = {};

obj.fo_o = d;  // Warning
({ a: obj.fo_o } = {d: d}); // No Warning
([ob.fo_o] = bar); // No Warning

What did you expect to happen?

I expect 3 warnings.

What actually happened? Please include the actual, raw output from ESLint.

One warning

The below cases are not warned

({ a: obj.fo_o } = {d: d}); // No warning
([ob.fo_o] = bar); // No Warning

Are you willing to submit a pull request to fix this bug?

Yes!

I think the proper behavior should be as belows.

/*eslint camelcase: ["error"] */
obj.fo_o = d; // warning
({ a: obj.fo_o } = bar); // warning
([ob.fo_o] = bar); // warning

/*eslint camelcase: ["error", {"ignoreDestructuring": true}] */
obj.fo_o = d; // warning
({ a: obj.fo_o } = bar); // warning
([ob.fo_o] = bar); // warning

/*eslint camelcase: ["error", {"properties": "never"}] */
obj.fo_o = d; // No warning
({ a: obj.fo_o } = {d: d}); // No warning
([ob.fo_o] = bar); // No warning

[mdjermanovic]

This looks like a bug to me, too.

Regarding ignoreDestructuring, I think it's only for shorthand variable initialization/assignments and in my opinion these should be errors:

/*eslint camelcase: ["error", {"ignoreDestructuring": true}] */

({ a: obj.fo_o } = bar); // error
([ob.fo_o] = bar); // error

[yeonjuan]

@mdjermanovic

Regarding ignoreDestructuring, I think it's only for shorthand variable initialization/assignments and in my opinion these should be errors:

Okay, I agreed. I changed the examples in the issue. Thanks.