Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: check assignment property target in camelcase (fixes #13025) #13027

Merged
merged 4 commits into from Mar 26, 2020
Merged

Fix: check assignment property target in camelcase (fixes #13025) #13027

merged 4 commits into from Mar 26, 2020

Conversation

yeonjuan
Copy link
Member

Prerequisites checklist

  • I have read the contributing guidelines.
  • The team has reached consensus on the changes proposed in this pull request. If not, I understand that the evaluation process will begin with this pull request and won't be merged until the team has reached consensus.

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

As mentioned in #13025, I added checking assignment property target in destructuring

Is there anything you'd like reviewers to focus on?

This PR, Fixes #13025

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Mar 11, 2020
@yeonjuan yeonjuan added bug ESLint is working incorrectly evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion rule Relates to ESLint's core rules and removed triage An ESLint team member will look at this issue soon labels Mar 11, 2020
kaicataldo
kaicataldo approved these changes Mar 20, 2020
View reviewed changes
Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kaicataldo kaicataldo added accepted There is consensus among the team that this change meets the criteria for inclusion and removed evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Mar 20, 2020
mdjermanovic
mdjermanovic requested changes Mar 23, 2020
View reviewed changes
lib/rules/camelcase.js Outdated Show resolved Hide resolved
lib/rules/camelcase.js Show resolved Hide resolved
lib/rules/camelcase.js Outdated Show resolved Hide resolved
@yeonjuan
Copy link
Member Author

@mdjermanovic Thanks for the review. I changed it.

mdjermanovic
mdjermanovic approved these changes Mar 26, 2020
View reviewed changes
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kaicataldo kaicataldo merged commit 0c20bc0 into master Mar 26, 2020
@kaicataldo kaicataldo deleted the issue13025 branch March 26, 2020 19:51
@kaicataldo
Copy link
Member

Thanks for contributing!

@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Sep 24, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Sep 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kaicataldo kaicataldo kaicataldo approved these changes

@mdjermanovic mdjermanovic mdjermanovic approved these changes

Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly rule Relates to ESLint's core rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[camelcase] false negative in destructuring with assignment
3 participants
@yeonjuan @kaicataldo @mdjermanovic