Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: removed correct code from incorrect eg section #13060

Merged
merged 1 commit into from Mar 21, 2020

Conversation

anikethsaha
Copy link
Member

@anikethsaha anikethsaha commented Mar 18, 2020

Prerequisites checklist

  • I have read the contributing guidelines.
  • The team has reached consensus on the changes proposed in this pull request. If not, I understand that the evaluation process will begin with this pull request and won't be merged until the team has reached consensus.

What is the purpose of this pull request? (put an "X" next to an item)

[X] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Removed the code from snippet which is correct but placed in the section for incorrect example
for quote-prop rule's always example in docs

check the snippet for incorrect

{
 "qux-lorem": true  // correct code
}

Is there anything you'd like reviewers to focus on?

demo

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Mar 18, 2020
@anikethsaha anikethsaha changed the title Docs: removed correct code from incorrect eg Docs: removed correct code from incorrect eg section Mar 18, 2020
Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kaicataldo kaicataldo added accepted There is consensus among the team that this change meets the criteria for inclusion documentation Relates to ESLint's documentation and removed triage An ESLint team member will look at this issue soon labels Mar 20, 2020
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@nzakas nzakas merged commit 0de91f3 into eslint:master Mar 21, 2020
anikethsaha added a commit to anikethsaha/eslint that referenced this pull request Mar 23, 2020
@anikethsaha anikethsaha deleted the quote-prop-docs branch March 31, 2020 11:40
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Sep 19, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Sep 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants