Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add further reading to rule #13084

Merged
merged 1 commit into from Mar 25, 2020
Merged

Add further reading to rule #13084

merged 1 commit into from Mar 25, 2020

Conversation

vegerot
Copy link
Contributor

@vegerot vegerot commented Mar 24, 2020 •
edited

This article really is the clearest explanation of this rule and how to understand it. Jake even mentions eslint and this rule in the article.

Prerequisites checklist

  • [x ] I have read the contributing guidelines.
  • The team has reached consensus on the changes proposed in this pull request. If not, I understand that the evaluation process will begin with this pull request and won't be merged until the team has reached consensus.

What is the purpose of this pull request? (put an "X" next to an item)

[x ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

@jsf-clabot
Copy link

jsf-clabot commented Mar 24, 2020 •
edited

CLA assistant check
All committers have signed the CLA.

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Mar 24, 2020
@vegerot
Docs: Add further reading to rule
ad74f0c 
This article really is the clearest explanation of this rule and how to understand it.
nzakas
nzakas approved these changes Mar 25, 2020
View reviewed changes
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@nzakas nzakas merged commit 76324ac into eslint:master Mar 25, 2020
@vegerot
Copy link
Contributor Author

vegerot commented Mar 25, 2020 •
edited

LGTM. Thanks!

lol, doesn't look good to me! Didn't notice it put them on the same line! 😳

@nzakas #13092

@vegerot vegerot mentioned this pull request Mar 25, 2020
Merged
1 task
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Sep 23, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Sep 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nzakas nzakas nzakas approved these changes

Assignees
No one assigned
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion triage An ESLint team member will look at this issue soon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vegerot @jsf-clabot @nzakas