Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: report operator location in operator-linebreak (refs #12334) #13102

Merged
merged 1 commit into from Mar 27, 2020
Merged

Update: report operator location in operator-linebreak (refs #12334) #13102

merged 1 commit into from Mar 27, 2020

Conversation

mdjermanovic
Copy link
Member

Prerequisites checklist

  • I have read the contributing guidelines.
  • The team has reached consensus on the changes proposed in this pull request. If not, I understand that the evaluation process will begin with this pull request and won't be merged until the team has reached consensus.

What is the purpose of this pull request? (put an "X" next to an item)

[X] Other, please explain:

refs #12334

This PR slightly changes reported location in the operator-linebreak rule.

It shouldn't produce any new warning possibly caused by the position of eslint-disable-* comments, because it doesn't change start.line.

What changes did you make? (Give an overview)

The rule will now report the full operator's location with start and end, instead of just its end location as the error's location.

Is there anything you'd like reviewers to focus on?

@mdjermanovic mdjermanovic added enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules accepted There is consensus among the team that this change meets the criteria for inclusion labels Mar 26, 2020
yeonjuan
yeonjuan approved these changes Mar 27, 2020
View reviewed changes
Copy link
Member

@yeonjuan yeonjuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kaicataldo kaicataldo merged commit 105384c into master Mar 27, 2020
@kaicataldo kaicataldo deleted the operatorlinebreak-loc branch March 27, 2020 21:22
@kaicataldo
Copy link
Member

Thanks!

@golopot golopot mentioned this pull request Mar 28, 2020
Closed
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Sep 24, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Sep 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kaicataldo kaicataldo kaicataldo approved these changes

@yeonjuan yeonjuan yeonjuan approved these changes

Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mdjermanovic @kaicataldo @yeonjuan