Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Improve report location for comma-style #13111

Merged
merged 1 commit into from Mar 31, 2020
Merged

Update: Improve report location for comma-style #13111

merged 1 commit into from Mar 31, 2020

Conversation

golopot
Copy link
Contributor

@golopot golopot commented Mar 28, 2020

Prerequisites checklist

  • I have read the contributing guidelines.
  • The team has reached consensus on the changes proposed in this pull request. If not, I understand that the evaluation process will begin with this pull request and won't be merged until the team has reached consensus.

What is the purpose of this pull request? (put an "X" next to an item)

[X] Other, please explain:

refs #12334

What changes did you make? (Give an overview)

Change the reported location in the comma-style rule. The rule will now report the full location of the comma token with start and end, instead of only end location.

Is there anything you'd like reviewers to focus on?

@kaicataldo
Copy link
Member

So sorry - our bot was not running when this PR was made. I'm going to close and reopen this to hopefully trigger the bot to run once more now that it's fixed.

@kaicataldo kaicataldo closed this Mar 28, 2020
@kaicataldo kaicataldo reopened this Mar 28, 2020
@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Mar 28, 2020
@kaicataldo
Copy link
Member

Looks like it worked 🎉

@kaicataldo kaicataldo added accepted There is consensus among the team that this change meets the criteria for inclusion rule Relates to ESLint's core rules enhancement This change enhances an existing feature of ESLint and removed triage An ESLint team member will look at this issue soon labels Mar 28, 2020
Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@nzakas nzakas merged commit 438dcbb into eslint:master Mar 31, 2020
@golopot golopot deleted the commastyle-loc branch March 31, 2020 03:18
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Sep 28, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Sep 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants