Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: no check for shadowed Object (fixes #12809) #13115

Merged
merged 1 commit into from Apr 1, 2020
Merged

Fix: no check for shadowed Object (fixes #12809) #13115

merged 1 commit into from Apr 1, 2020

Conversation

anikethsaha
Copy link
Member

Prerequisites checklist

  • I have read the contributing guidelines.
  • The team has reached consensus on the changes proposed in this pull request. If not, I understand that the evaluation process will begin with this pull request and won't be merged until the team has reached consensus.

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[X] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

fixes #12809

What changes did you make? (Give an overview)

added a no check for shadow Object calls

Is there anything you'd like reviewers to focus on?

#12809

I didn't use the referenceTracker as mentioned in the issue to avoid further bugs.

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Mar 28, 2020
@kaicataldo kaicataldo added accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly rule Relates to ESLint's core rules and removed triage An ESLint team member will look at this issue soon labels Mar 30, 2020
nzakas
nzakas approved these changes Mar 31, 2020
View reviewed changes
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@kaicataldo kaicataldo merged commit 7551f0c into eslint:master Apr 1, 2020
@kaicataldo
Copy link
Member

Thank you for contributing!

@anikethsaha anikethsaha deleted the fixes-12809 branch April 1, 2020 16:34
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Sep 29, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Sep 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nzakas nzakas nzakas approved these changes

@kaicataldo kaicataldo kaicataldo approved these changes

Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly rule Relates to ESLint's core rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

no-new-object: warns on non-global Object instantiation
3 participants
@anikethsaha @kaicataldo @nzakas