Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: clarify exceptions in spaced-comment (fixes #13032) #13126

Merged
merged 4 commits into from Apr 4, 2020
Merged

Docs: clarify exceptions in spaced-comment (fixes #13032) #13126

merged 4 commits into from Apr 4, 2020

Conversation

anikethsaha
Copy link
Member

Prerequisites checklist

  • I have read the contributing guidelines.
  • The team has reached consensus on the changes proposed in this pull request. If not, I understand that the evaluation process will begin with this pull request and won't be merged until the team has reached consensus.

What is the purpose of this pull request? (put an "X" next to an item)

[X] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Updated the exceptions definition for new line issue

Is there anything you'd like reviewers to focus on?

fixes #13032

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Mar 31, 2020
kaicataldo
kaicataldo suggested changes Apr 1, 2020
View reviewed changes
Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

docs/rules/spaced-comment.md Outdated Show resolved Hide resolved
docs/rules/spaced-comment.md Outdated Show resolved Hide resolved
docs/rules/spaced-comment.md Show resolved Hide resolved
@kaicataldo kaicataldo added documentation Relates to ESLint's documentation and removed triage An ESLint team member will look at this issue soon labels Apr 1, 2020
kaicataldo
kaicataldo approved these changes Apr 1, 2020
View reviewed changes
Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

mdjermanovic
mdjermanovic requested changes Apr 2, 2020
View reviewed changes
docs/rules/spaced-comment.md Outdated Show resolved Hide resolved
docs/rules/spaced-comment.md Outdated Show resolved Hide resolved
docs/rules/spaced-comment.md Outdated Show resolved Hide resolved
@mdjermanovic mdjermanovic added accepted There is consensus among the team that this change meets the criteria for inclusion rule Relates to ESLint's core rules labels Apr 3, 2020
@mdjermanovic mdjermanovic changed the title Docs: update exception details to cover newline issue (fixes #13032) Docs: clarify exceptions in spaced-comment (fixes #13032) Apr 3, 2020
mdjermanovic
mdjermanovic approved these changes Apr 4, 2020
View reviewed changes
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kaicataldo
Copy link
Member

Thanks for contributing!

@kaicataldo kaicataldo merged commit adc8fa8 into eslint:master Apr 4, 2020
@anikethsaha anikethsaha deleted the fixes-13032 branch April 4, 2020 20:34
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Oct 2, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Oct 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kaicataldo kaicataldo kaicataldo approved these changes

@mdjermanovic mdjermanovic mdjermanovic approved these changes

Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation rule Relates to ESLint's core rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

spaced-comment: Clarify support for single line comments
3 participants
@anikethsaha @kaicataldo @mdjermanovic