Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Improve report location for space-before-function-paren #13128

Merged
merged 1 commit into from Apr 3, 2020
Merged

Update: Improve report location for space-before-function-paren #13128

merged 1 commit into from Apr 3, 2020

Conversation

golopot
Copy link
Contributor

@golopot golopot commented Apr 1, 2020

Prerequisites checklist

  • I have read the contributing guidelines.
  • The team has reached consensus on the changes proposed in this pull request. If not, I understand that the evaluation process will begin with this pull request and won't be merged until the team has reached consensus.

What is the purpose of this pull request? (put an "X" next to an item)

[x] Other, please explain:

refs #12334.

What changes did you make? (Give an overview)

  1. Add end location for cases with extra space.
  2. Change the report location to that of opening parenthesis for cases with missing space.
// Before
/* eslint space-before-function-paren: [2, 'never'] */
function foo () {}
//       ~~~   vscode highlight

/* eslint space-before-function-paren: [2, 'always'] */
function foo() {}
//       ~~~   vscode highlight

// Now
/* eslint space-before-function-paren: [2, 'never'] */
function foo () {}
//          ~   vscode highlight

/* eslint space-before-function-paren: [2, 'always'] */
function foo() {}
//          ~   vscode highlight

Is there anything you'd like reviewers to focus on?

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Apr 1, 2020
@golopot golopot changed the title Update: Improve report location for space-before-function-paren (refs #12334) Update: Improve report location for space-before-function-paren Apr 1, 2020
@kaicataldo kaicataldo added accepted There is consensus among the team that this change meets the criteria for inclusion enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules and removed triage An ESLint team member will look at this issue soon labels Apr 1, 2020
Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Copy link
Member

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might look a bit strange if there are comments between, e.g.:

image

Thoughts? I'm not sure if any other solution would make more sense, but it would be nice to discuss this before fixing all spacing rules.

@golopot
Copy link
Contributor Author

golopot commented Apr 3, 2020

This case is rare enough that people will spent very little time bothering it. Further improvements will yield very little benefit. So in terms of benefit-cost ratio, the current behavior is good enough.

Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed! LGTM, thanks!

@kaicataldo kaicataldo merged commit 5e07574 into eslint:master Apr 3, 2020
@kaicataldo
Copy link
Member

Thanks for contributing!

@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Oct 1, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Oct 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants