Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: report backtick loc in no-unexpected-multiline (refs #12334) #13142

Merged
merged 1 commit into from Apr 24, 2020

Conversation

mdjermanovic
Copy link
Member

Prerequisites checklist

  • I have read the contributing guidelines.
  • The team has reached consensus on the changes proposed in this pull request. If not, I understand that the evaluation process will begin with this pull request and won't be merged until the team has reached consensus.

What is the purpose of this pull request? (put an "X" next to an item)

[X] Other, please explain:

refs #12334

Change reported location in the no-unexpected-multiline rule.

For tagged template literals, this change can produce more warnings in existing code, depending on the location of eslint-disable-* comments.

What changes did you make? (Give an overview)

  • Tagged template literals: rule will now report template literal's backtick location, instead of tag's start location. This is consistent with other node types.
  • All other nodes: rule will now report the full location of (, [, /, instead of just their start locations.

Before:

image

After:

image

Is there anything you'd like reviewers to focus on?

An existing code like the following will have a no-unexpected-multiline error after this change:

/* eslint no-unexpected-multiline: ["error"] */

// eslint-disable-next-line no-unexpected-multiline
a
`b`

Other changes:

  • data isn't used in error messages, so it's removed.
  • if (node.tag.loc.end.line === node.quasi.loc.start.line) conditional was redundant, so it's removed.
  • Formatting for the last test case (tagged-template-with-generic-and-comment) was wrong, so it's fixed to match the actual input (which is observable from the reported location).

@mdjermanovic mdjermanovic added enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules accepted There is consensus among the team that this change meets the criteria for inclusion labels Apr 4, 2020
Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for better consistency in the error report location. LGTM, thanks!

Copy link
Member

@yeonjuan yeonjuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@kaicataldo kaicataldo merged commit d3aac53 into master Apr 24, 2020
@kaicataldo kaicataldo deleted the nounexpectedmultiline-loc branch April 24, 2020 19:59
@kaicataldo
Copy link
Member

Thanks for contributing!

@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Oct 22, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Oct 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants