Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: fix curly multi-or-nest examples with comments (refs #12972) #13151

Merged
merged 1 commit into from Apr 7, 2020

Conversation

mdjermanovic
Copy link
Member

Prerequisites checklist

  • I have read the contributing guidelines.
  • The team has reached consensus on the changes proposed in this pull request. If not, I understand that the evaluation process will begin with this pull request and won't be merged until the team has reached consensus.

What is the purpose of this pull request? (put an "X" next to an item)

[X] Documentation update

refs #12972

What changes did you make? (Give an overview)

Fixed multi-or-nest examples with preceding comments in the curly rule to match the actual behavior and added a note to clarify the logic.

Is there anything you'd like reviewers to focus on?

@mdjermanovic mdjermanovic added rule Relates to ESLint's core rules documentation Relates to ESLint's documentation accepted There is consensus among the team that this change meets the criteria for inclusion labels Apr 6, 2020
@kaicataldo
Copy link
Member

LGTM, thanks!

@nzakas nzakas merged commit c41de38 into master Apr 7, 2020
@nzakas nzakas deleted the curlymultinest-examples branch April 7, 2020 00:10
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Oct 5, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Oct 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants