Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade: some (dev) deps #13155

Merged
merged 5 commits into from Apr 24, 2020
Merged

Upgrade: some (dev) deps #13155

merged 5 commits into from Apr 24, 2020

Conversation

aladdin-add
Copy link
Member

@aladdin-add aladdin-add commented Apr 7, 2020

Prerequisites checklist

  • I have read the contributing guidelines.
  • The team has reached consensus on the changes proposed in this pull request. If not, I understand that the evaluation process will begin with this pull request and won't be merged until the team has reached consensus.

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

What changes did you make? (Give an overview)

as the title.

Is there anything you'd like reviewers to focus on?

  1. after upgrading eslint-plugin-jsdoc, it reports:
    "Invalid JSDoc tag name "template" jsdoc/check-tag-names"
    it was fixed by adding setting.jsdoc.mode: "typescript"
    (refs:https://github.com/gajus/eslint-plugin-jsdoc#check-tag-names)

  2. the following deps were not upgraded:

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Apr 7, 2020
@aladdin-add aladdin-add added accepted There is consensus among the team that this change meets the criteria for inclusion upgrade This change is related to a dependency upgrade and removed triage An ESLint team member will look at this issue soon labels Apr 7, 2020
@@ -20,8 +20,8 @@
"homepage": "https://eslint.org",
"bugs": "https://github.com/eslint/eslint/issues/",
"peerDependencies": {
"eslint-plugin-jsdoc": "^15.9.5",
"eslint-plugin-node": "^9.0.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thanks for catching this. I missed this in my PR.

Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, looks like my PR caused some merge conflicts.

1. after upgrading eslint-plugin-jsdoc, it reports:
"Invalid JSDoc tag name "template"  jsdoc/check-tag-names"

it was fixed by added setting.jsdoc.mode: typescript
(refs:https://github.com/gajus/eslint-plugin-jsdoc#check-tag-names)

2. the following deps were not upgraded:
* levn (was upgraded in #13140)
* ignore (it has a few breaking change)
@aladdin-add
Copy link
Member Author

I've rebased master. @kaicataldo

Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

lib/shared/relative-module-resolver.js Outdated Show resolved Hide resolved
.eslintrc.js Show resolved Hide resolved
@nzakas
Copy link
Member

nzakas commented Apr 23, 2020

@kaicataldo has your feedback been addressed?

Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@aladdin-add aladdin-add merged commit 3eeae56 into master Apr 24, 2020
@aladdin-add aladdin-add deleted the upgrade/deps branch April 24, 2020 02:40
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Oct 22, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Oct 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion upgrade This change is related to a dependency upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants