Update: Improve report location for getter-return (refs #12334) #13164
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[X] Other, please explain:
refs #12334
Change reported location in the
getter-return
rule.This change can produce more warnings in existing code, depending on the location of
eslint-disable-*
comments.What changes did you make? (Give an overview)
The rule will now use
astUtils.getFunctionHeadLoc
instead of its own code for the reported getter's location.Some notable differences
Before:
After:
Is there anything you'd like reviewers to focus on?
In edge cases where
get
and the opening paren are not on the same line, this change can produce more warnings. For example, the following code will be invalid now: