New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comma dangle syntax no longer ignores functions: never #13165
Comments
Hi @willlma, thanks for the bug report! The actual bug, in this case, is that the rule doesn't report invalid configuration and just ignores the extra option Your configuration works the same as: comma-dangle: [warn, always-multiline] Per the documentation, it should be either a string option or an object option. This particular rule doesn't support overriding the specified string option with an additional object option. The correct configuration would be: comma-dangle: [warn, {
"arrays": "always-multiline",
"objects": "always-multiline",
"imports": "always-multiline",
"exports": "always-multiline",
"functions": "never"
}] In v6.5.1 |
Unfortunately, it looks like there wasn't enough interest from the team Thanks for contributing to ESLint and we appreciate your understanding. |
Reopening because this looks like a bug in the rule's schema. |
@mdjermanovic Do you mind marking this as accepted if you've verified this bug and outlining what you believe the correct fix is here? That way someone from the community could pick this up! |
Marked as accepted. PR #13166 to fix this is prepared, we're just not sure whether this can be a semver-minor fix or should we treat it as a breaking change. |
Tell us about your environment
Upgraded from 6.51 to 6.8.0
v13.12.0
Using yarn: 1.22.4
What parser (default, Babel-ESLint, etc.) are you using?
Babel-ESLint
Please show your full configuration:
Configuration
What did you do? Please include the actual source code causing the issue, as well as the command that you used to run ESLint.
What did you expect to happen?
No warnings. My
.eslintrc
specifieswhich worked prior to this upgrade
What actually happened? Please include the actual, raw output from ESLint.
Are you willing to submit a pull request to fix this bug?
No
The text was updated successfully, but these errors were encountered: