Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

func-call-spacing reports "unexpected newline", when there is a space (not a newline) #13190

Closed
ChumpChief opened this issue Apr 16, 2020 · 1 comment · Fixed by #13193
Closed

func-call-spacing reports "unexpected newline", when there is a space (not a newline) #13190

ChumpChief opened this issue Apr 16, 2020 · 1 comment · Fixed by #13193
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly rule Relates to ESLint's core rules

Comments

@ChumpChief
Copy link

Just suggesting an update to the error string. Based on the comments in the rule, looks like there were intended to be three distinct messages, rather than just the two.

Tell us about your environment

  • ESLint Version: 6.8.0
  • Node Version: 12.13.0
  • npm Version: 6.12.0

What parser (default, Babel-ESLint, etc.) are you using?
@typescript-eslint/parser

Please show your full configuration:

Configuration 
"func-call-spacing": "error"

What did you do? Please include the actual source code causing the issue, as well as the command that you used to run ESLint.

console.log ("hi");
npm run eslint

What did you expect to happen?
error Unexpected whitespace between function name and paren func-call-spacing

What actually happened? Please include the actual, raw output from ESLint.
error Unexpected newline between function name and paren func-call-spacing

Are you willing to submit a pull request to fix this bug?
No
@ChumpChief ChumpChief added bug ESLint is working incorrectly triage An ESLint team member will look at this issue soon labels Apr 16, 2020
@mdjermanovic mdjermanovic added accepted There is consensus among the team that this change meets the criteria for inclusion rule Relates to ESLint's core rules and removed triage An ESLint team member will look at this issue soon labels Apr 18, 2020
@mdjermanovic
Copy link
Member

Hi @ChumpChief, thanks for the bug report!

Confirmed in online demo. We should fix this, I'm working on it.

mdjermanovic added a commit that referenced this issue Apr 18, 2020
@mdjermanovic
Fix: func-call-spacing "never" reports wrong message (fixes #13190)
a4cbab6
@mdjermanovic mdjermanovic mentioned this issue Apr 18, 2020
Merged
2 tasks
kaicataldo pushed a commit that referenced this issue Apr 24, 2020
@mdjermanovic
Fix: func-call-spacing "never" reports wrong message (fixes #13190) (#…
8e7a2d9 
…13193)
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Oct 22, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Oct 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly rule Relates to ESLint's core rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: func-call-spacing "never" reports wrong message (fixes #13190) eslint/eslint
2 participants
@ChumpChief @mdjermanovic