Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: add rule comment in prefer-rest-params doc #13191

Merged
merged 1 commit into from Apr 18, 2020
Merged

Docs: add rule comment in prefer-rest-params doc #13191

merged 1 commit into from Apr 18, 2020

Conversation

yeonjuan
Copy link
Member

Prerequisites checklist

  • I have read the contributing guidelines.
  • The team has reached consensus on the changes proposed in this pull request. If not, I understand that the evaluation process will begin with this pull request and won't be merged until the team has reached consensus.

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Add eslint configuring rule comment in prefer-rest-params.md

Is there anything you'd like reviewers to focus on?

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Apr 17, 2020
@yeonjuan yeonjuan added the documentation Relates to ESLint's documentation label Apr 17, 2020
@aladdin-add aladdin-add added accepted There is consensus among the team that this change meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon labels Apr 17, 2020
aladdin-add
aladdin-add approved these changes Apr 17, 2020
View reviewed changes
Copy link
Member

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic added the rule Relates to ESLint's core rules label Apr 18, 2020
@mdjermanovic
Copy link
Member

LGTM, there is just a small typo in the commit message and the title:

prefer-rest-prams -> prefer-rest-params

@yeonjuan yeonjuan changed the title Docs: add rule comment in prefer-rest-prams doc Docs: add rule comment in prefer-rest-params doc Apr 18, 2020
mdjermanovic
mdjermanovic approved these changes Apr 18, 2020
View reviewed changes
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@aladdin-add aladdin-add merged commit b398e0b into master Apr 18, 2020
@aladdin-add aladdin-add deleted the docs-preferrestparams branch April 18, 2020 15:25
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Oct 16, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Oct 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aladdin-add aladdin-add aladdin-add approved these changes

@mdjermanovic mdjermanovic mdjermanovic approved these changes

Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation rule Relates to ESLint's core rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yeonjuan @mdjermanovic @aladdin-add