[no-magic-numbers] - default parameter values

[avalanche1]

Tell us about your environment

• ESLint Version:
  ^7.0.0-alpha.2

What did you do? Please include the actual source code causing the issue, as well as the command that you used to run ESLint.

function foo(param = 3000) {
  // code
}

What did you expect to happen?
eslint will not complain
What actually happened? Please include the actual, raw output from ESLint.
No magic number: 3000

I think magic numbers in default values for function params either:

• should not be reported
• provide an option to the rule to omit those

The whole point of default values is to specify the value, is it not?

[anikethsaha]

I think it does make sense to ignore default arguments of a function as a separate options.
+1 for this

[mdjermanovic]

I think this is correct default behavior, but an option to omit those makes sense to me.

There is already proposal/PR #12611 that includes default values for function params, as clarified in the discussion.

@avalanche1 would you prefer a separate option for function params only?

[avalanche1]

#12611 looks fine by me.
actually I wan't aware of default params with destructuring assignment

[eslint-deprecated]

Unfortunately, it looks like there wasn't enough interest from the team
or community to implement this change. While we wish we'd be able to
accommodate everyone's requests, we do need to prioritize. We've found
that issues failing to reach accepted status after 21 days tend to
never be accepted, and as such, we close those issues.
This doesn't mean the idea isn't interesting or useful, just that it's
not something the team can commit to.

Thanks for contributing to ESLint and we appreciate your understanding.