Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: fix typos #13204

Merged
merged 2 commits into from Apr 23, 2020
Merged

Docs: fix typos #13204

merged 2 commits into from Apr 23, 2020

Conversation

snitin315
Copy link
Contributor

@snitin315 snitin315 commented Apr 21, 2020 •
edited

Prerequisites checklist

  • I have read the contributing guidelines.
  • The team has reached consensus on the changes proposed in this pull request. If not, I understand that the evaluation process will begin with this pull request and won't be merged until the team has reached consensus.

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Fixed several typos across the project.

Is there anything you'd like reviewers to focus on?

No

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Apr 21, 2020
kaicataldo
kaicataldo suggested changes Apr 21, 2020
View reviewed changes
docs/rules/valid-typeof.md Outdated Show resolved Hide resolved
tests/lib/rules/no-implied-eval.js Outdated Show resolved Hide resolved
tests/bench/large.js Show resolved Hide resolved
tests/performance/jshint.js Show resolved Hide resolved
@kaicataldo
Copy link
Member

Thanks for working on this!

@mdjermanovic mdjermanovic added accepted There is consensus among the team that this change meets the criteria for inclusion documentation Relates to ESLint's documentation and removed triage An ESLint team member will look at this issue soon labels Apr 22, 2020
@mdjermanovic mdjermanovic changed the title Chore: fix typos Docs: fix typos Apr 22, 2020
@mdjermanovic
Copy link
Member

Changed the PR title to start with Docs: because there is one change in the user-facing docs.

mdjermanovic
mdjermanovic approved these changes Apr 22, 2020
View reviewed changes
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

kaicataldo
kaicataldo approved these changes Apr 23, 2020
View reviewed changes
Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kaicataldo kaicataldo merged commit 56d2bee into eslint:master Apr 23, 2020
@snitin315 snitin315 deleted the fix/typos branch April 23, 2020 04:04
@snitin315 snitin315 mentioned this pull request May 2, 2020
Closed
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Oct 21, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Oct 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nzakas nzakas nzakas approved these changes

@kaicataldo kaicataldo kaicataldo approved these changes

@shivaylamba shivaylamba shivaylamba approved these changes

@mdjermanovic mdjermanovic mdjermanovic approved these changes

Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@snitin315 @kaicataldo @mdjermanovic @nzakas @shivaylamba