Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: fix rules list for prereleases #13230

Merged
merged 3 commits into from May 8, 2020
Merged

Chore: fix rules list for prereleases #13230

merged 3 commits into from May 8, 2020

Conversation

kaicataldo
Copy link
Member

@kaicataldo kaicataldo commented Apr 27, 2020

Prerequisites checklist

  • I have read the contributing guidelines.
  • The team has reached consensus on the changes proposed in this pull request. If not, I understand that the evaluation process will begin with this pull request and won't be merged until the team has reached consensus.

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[X] Other, please explain:

Chore

What changes did you make? (Give an overview)

Our current https://eslint.org/docs/rules/ page has broken links to rules that were added in the current prerelease because it updates the website repo's _data/rules.yml data file during prereleases (while outputting all the prerelease documentation to docs/7.0.0/ in the eslint/website repo). I think this fixes the problem.

Is there anything you'd like reviewers to focus on?

Is there anything I have missed?

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Apr 27, 2020
@kaicataldo kaicataldo added chore This change is not user-facing and removed triage An ESLint team member will look at this issue soon labels Apr 27, 2020
@kaicataldo kaicataldo merged commit 401a687 into master May 8, 2020
@kaicataldo kaicataldo deleted the fix-broken-rules branch May 8, 2020 17:00
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Nov 5, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Nov 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants