New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update: added typescript-eslint/recommended configs for init #13235
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM (and I support this change), but I'm not sure why this has been marked as accepted. I think we'll want to go through our standard proposal acceptance process for this. @aladdin-add Mind filling us in on why this has been marked as accepted?
@kaicataldo I am sorry as I submitted PR without the accepted label. I did as this was a small change and it was mentioned in the typescript-eslint repo so I thought of moving it fast with PR and discussing in the PR. |
removed sorry for confusion! 😄 |
@anikethsaha No need to apologize - there's nothing wrong with submitting a PR before it's accepted! In fact, it makes it easier for us to evaluate the proposal :). I just want to make sure we go through our standard process so that the whole team has the chance to evaluate the proposal. @aladdin-add No problem! |
I'll champion this. We just need 3 👍s from the team to accept this. |
It make sense to me. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Thanks for contributing! |
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[X] Other, please explain:
init
flag refactorWhat changes did you make? (Give an overview)
added
"plugin:@typescript-eslint/recommended"
to extend configs when typescript prompt istrue
.Is there anything you'd like reviewers to focus on?
fixes #13233
ref https://github.com/typescript-eslint/typescript-eslint/tree/master/packages/eslint-plugin#recommended-configs