Upgrade ignore to 5.x?

[kaelzhang]

The version of ESLint you are using.

7.0.0

The problem you want to solve.

The latest eslint still uses ignore@^4.0.6, but the latest version of ignore@5.1.3 solves many known issues.

• .gitignore(.eslintignore) rules should always check paths that are relative to some directory which is usually the base dir of .gitignore file or the root directory of a repo. ignore <= 5 actually DONT KNOWN whether a pathname should be ignored if it is an absolute path.
• and also improves perf
• fixes some windows issues.

For details, we could check releases

Are you willing to submit a pull request to implement this change?

I'd like to help.

I submit this issue in order to discuss the necessarity whether we should do an upgrade which might introduce quite a few changes.

[kaicataldo]

Upgrading to latest to take advantage of the things you listed above sounds great. Looking at the migration docs, is it true that we could avoid it being a breaking change for our users by filtering out the invalid paths?

[mysticatea]

Currently, we allow relative paths to the parent (../*), so I think we need breaking changes to upgrade.

[kaelzhang]

Currently, we allow relative paths to the parent (../*), so I think we need breaking changes to upgrade.

@mysticatea Those relative paths to the parent (../*) is defined in .eslintignore file or command-line arguments

[kaelzhang]

Upgrading to latest to take advantage of the things you listed above sounds great. Looking at the migration docs, is it true that we could avoid it being a breaking change for our users by filtering out the invalid paths?

@kaicataldo I guess it is possible to make a smooth upgrade.

[eslint-deprecated]

Unfortunately, it looks like there wasn't enough interest from the team
or community to implement this change. While we wish we'd be able to
accommodate everyone's requests, we do need to prioritize. We've found
that issues failing to reach accepted status after 21 days tend to
never be accepted, and as such, we close those issues.
This doesn't mean the idea isn't interesting or useful, just that it's
not something the team can commit to.

Thanks for contributing to ESLint and we appreciate your understanding.

[metasean]

fwiw: The ignore package is now up to release v.5.1.5

[bmish]

Reopening since should be able to upgrade this in a major release at some point: #14889