New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Mark SourceCode getComments() method as deprecated (fixes #13293) #13296
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that SouceCode#getComments()
is deprecated, we won't be accepting any more PRs to change the behavior. A PR updating the JSDoc block to include an @deprecated
tag would be welcome, though!
Thank you, update PR! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we change the commit message from Docs:
to Chore:
? We reserve Docs:
for publicly visible documentation.
Otherwise, this LGTM!
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
|
LGTM, thank you! |
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Update source-code.js
getComments
method:Program node exclude leading and trailing comments from our range, and i add special conditions, when given node has parent Program, leading and trailing comments tokens always belong to this node