Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: fix broken link in Node.js API docs #13307

Merged
merged 1 commit into from May 19, 2020

Conversation

kaicataldo
Copy link
Member

@kaicataldo kaicataldo commented May 15, 2020

Prerequisites checklist

  • I have read the contributing guidelines.
  • The team has reached consensus on the changes proposed in this pull request. If not, I understand that the evaluation process will begin with this pull request and won't be merged until the team has reached consensus.

What is the purpose of this pull request? (put an "X" next to an item)

[X] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

As noted in #13302, this link is currently broken. The author was not able to sign the CLA and so the PR was closed. Thanks @spl for bringing this to our attention!

Is there anything you'd like reviewers to focus on?

Nothing in particular.

As noted in #13302, this link is currently broken.
@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label May 15, 2020
@kaicataldo kaicataldo added documentation Relates to ESLint's documentation and removed triage An ESLint team member will look at this issue soon labels May 15, 2020
Copy link
Member

@yeonjuan yeonjuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kaicataldo kaicataldo merged commit 7f14846 into master May 19, 2020
@kaicataldo kaicataldo deleted the fix-broken-link-nodejs-api branch May 19, 2020 16:40
@mysticatea
Copy link
Member

Hmm.

The page in GitHub (/docs/developer-guide/nodejs-api.md) looks broken by this change. Can our website generator convert links from GitHub way to our website way?

@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Nov 16, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Nov 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants