Fix: arrow-parens no reporting for comments inside (fixes #12995)

[anikethsaha]

Prerequisites checklist

• I have read the contributing guidelines.
• The team has reached consensus on the changes proposed in this pull request. If not, I understand that the evaluation process will begin with this pull request and won't be merged until the team has reached consensus.

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[X] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

rule: arrow-parens

no reporting when there are comments inside params.
applicable for as-needed option for

Example of valid code (these are invalid in master as of now)

/*eslint arrow-parens: ["error", "as-needed"]*/


const f = (/** @type {number} */a/**hello*/) => a + a;
const ff = (a /**/) => a
const fff = (//
a) => a

These are valid by default in master as well

Is there anything you'd like reviewers to focus on?

None

[anikethsaha]

@mdjermanovic I added a check for opening parent before first token for having the false positive which you mentioned

/* eslint arrow-parens: ["error", "always"] */

var foo = /**/ a => b;

the other way for this was to check if the option is as-needed or not.

Let me know if the current change is fine 👍

[mdjermanovic]

Works good, I left some comments where it seems that the code could be simplified a bit.

Can we also add some examples to the docs for "as-needed"?

[mdjermanovic]

LGTM, thanks!

[kaicataldo]

Thank you!