Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: report end loc in one-var-declaration-per-line (refs #12334) #13326

Merged
merged 1 commit into from May 22, 2020
Merged

Fix: report end loc in one-var-declaration-per-line (refs #12334) #13326

merged 1 commit into from May 22, 2020

Conversation

yeonjuan
Copy link
Member

Prerequisites checklist

  • I have read the contributing guidelines.
  • The team has reached consensus on the changes proposed in this pull request. If not, I understand that the evaluation process will begin with this pull request and won't be merged until the team has reached consensus.

What is the purpose of this pull request? (put an "X" next to an item)

[x] Other, please explain:

ref #12334

What changes did you make? (Give an overview)

added loc.end to report in one-var-declaration-per-line.

Is there anything you'd like reviewers to focus on?

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label May 19, 2020
@golopot golopot mentioned this pull request May 19, 2020
Closed
@yeonjuan yeonjuan added accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly rule Relates to ESLint's core rules and removed triage An ESLint team member will look at this issue soon labels May 19, 2020
@yeonjuan yeonjuan force-pushed the onevardeclarationperline-loc branch from 0e67022 to f9f237c Compare May 19, 2020 12:07
@yeonjuan yeonjuan changed the title Fix: report end loc in one-var-declaration-per-line (refs: #12334) Fix: report end loc in one-var-declaration-per-line (refs #12334) May 19, 2020
mdjermanovic
mdjermanovic approved these changes May 21, 2020
View reviewed changes
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kaicataldo kaicataldo merged commit de0aab9 into master May 22, 2020
@kaicataldo kaicataldo deleted the onevardeclarationperline-loc branch May 22, 2020 23:36
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Nov 19, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Nov 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kaicataldo kaicataldo kaicataldo approved these changes

@mdjermanovic mdjermanovic mdjermanovic approved these changes

Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly rule Relates to ESLint's core rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yeonjuan @kaicataldo @mdjermanovic