Fix: fix false positives of no-new-func #13333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g-plane
added
bug
kaicataldo
suggested changes
May 20, 2020
mdjermanovic
requested changes
May 21, 2020
mdjermanovic
requested changes
May 21, 2020
kaicataldo
approved these changes
May 22, 2020
|
LGTM, thanks! |
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[x] Bug fix
What changes did you make? (Give an overview)
Previously this rule doesn't check
Functionidentifier via scope manager, which causes false positives. This PR fixes this.Online demo with the rule that has bug.
Is there anything you'd like reviewers to focus on?
Nothing.