Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: max-lines-per-function flagging arrow IIFEs (fixes #13332) #13336

Merged
merged 1 commit into from May 23, 2020
Merged

Fix: max-lines-per-function flagging arrow IIFEs (fixes #13332) #13336

merged 1 commit into from May 23, 2020

Conversation

cherryblossom000
Copy link
Contributor

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

Fixes #13332.

What changes did you make? (Give an overview)

Include a check if the node is an ArrowFunctionExpression in isIIFE in max-lines-per-function.

Is there anything you'd like reviewers to focus on?

No.

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label May 21, 2020
@cherryblossom000 cherryblossom000 changed the title Fix: Max lines per function rule incorrectly flagging arrow IFFEs (fixes #13332) Fix: Max lines per function flagging arrow IFFEs (fixes #13332) May 21, 2020
@mdjermanovic mdjermanovic added accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly rule Relates to ESLint's core rules and removed triage An ESLint team member will look at this issue soon labels May 21, 2020
mdjermanovic
mdjermanovic requested changes May 21, 2020
View reviewed changes
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just there is a typo in commit message/PR title: IFFEs -> IIFEs.

Could you please also change the start of the message/title to match the rule's name: max-lines-per-function

@cherryblossom000 cherryblossom000 changed the title Fix: Max lines per function flagging arrow IFFEs (fixes #13332) Fix: Max lines per function flagging arrow IIFEs (fixes #13332) May 21, 2020
@cherryblossom000
Copy link
Contributor Author

@mdjermanovic Done.

@mdjermanovic mdjermanovic changed the title Fix: Max lines per function flagging arrow IIFEs (fixes #13332) Fix: max-lines-per-function flagging arrow IIFEs (fixes #13332) May 21, 2020
mdjermanovic
mdjermanovic approved these changes May 21, 2020
View reviewed changes
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

kaicataldo
kaicataldo approved these changes May 21, 2020
View reviewed changes
Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@kaicataldo kaicataldo merged commit bd3f092 into eslint:master May 23, 2020
@kaicataldo
Copy link
Member

Thanks for contributing!

@cherryblossom000 cherryblossom000 deleted the max-lines-per-function-arrow-iifes branch May 23, 2020 01:16
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Nov 20, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Nov 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kaicataldo kaicataldo kaicataldo approved these changes

@mdjermanovic mdjermanovic mdjermanovic approved these changes

Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly rule Relates to ESLint's core rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

max-lines-per-function ignores arrow IIFEs
3 participants
@cherryblossom000 @kaicataldo @mdjermanovic