Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Drop @typescript-eslint/eslint-recommended from eslint --init #13340

Merged
merged 1 commit into from Jun 11, 2020

Conversation

NMinhNguyen
Copy link
Contributor

@NMinhNguyen NMinhNguyen commented May 22, 2020

@typescript-eslint/recommended now extends from @typescript-eslint/eslint-recommended:
https://github.com/typescript-eslint/typescript-eslint/releases/tag/v3.0.0

/cc @bradzacher

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[X] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Removed @typescript-eslint/eslint-recommended because it's no longer necessary.

Is there anything you'd like reviewers to focus on?

No

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label May 22, 2020
@NMinhNguyen NMinhNguyen changed the title Update: Remove @typescript-eslint/eslint-recommended from eslint --init Update: Drop @typescript-eslint/eslint-recommended from eslint --init May 22, 2020
@kaicataldo
Copy link
Member

I don't think we should do this yet because this would not enable the rules for anyone still on the previous major release line (most likely the majority of users, since this was just released). If we want to do this, we need to add a check to see if @typescript-eslint/eslint-plugin is v2 or v3 and adjust the config accordingly.

@kaicataldo kaicataldo added core Relates to ESLint's core APIs and features enhancement This change enhances an existing feature of ESLint evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon labels May 23, 2020
@NMinhNguyen
Copy link
Contributor Author

NMinhNguyen commented May 23, 2020

Oh I was under the impression that eslint --init was for bootstrapping from scratch (e.g. the file is called config-initializer implying there’s no existing config and one is being initialised) and that by default it would install the latest version (v3) of @typescript-eslint dependencies

@nzakas
Copy link
Member

nzakas commented Jun 11, 2020

@kaicataldo I believe this is safe to change. We are installing the latest typescript-eslint when doing --init, so the latest recommendation for how to setup a config should be followed.

@kaicataldo kaicataldo merged commit 6cfbd03 into eslint:master Jun 11, 2020
@kaicataldo
Copy link
Member

Thanks for contributing!

@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Dec 9, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion core Relates to ESLint's core APIs and features enhancement This change enhances an existing feature of ESLint evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants