Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Update new rules policies #13343

Merged
merged 2 commits into from May 22, 2020
Merged

Docs: Update new rules policies #13343

merged 2 commits into from May 22, 2020

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented May 22, 2020

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Updated the new rules policy to reflect recent decision.

Is there anything you'd like reviewers to focus on?

Spelling. :)

@nzakas nzakas added documentation Relates to ESLint's documentation accepted There is consensus among the team that this change meets the criteria for inclusion labels May 22, 2020
@aladdin-add
Copy link
Member

aladdin-add commented May 22, 2020

should also update the new-rule issue template? or I can make another PR. 😄

@nzakas
Copy link
Member Author

nzakas commented May 22, 2020

That's a good idea! I'll add to this PR.

Copy link
Member

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💯

@nzakas nzakas merged commit 611c676 into master May 22, 2020
@nzakas nzakas deleted the rules-docs-update branch May 22, 2020 17:25
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Nov 19, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Nov 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants