Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: semi-spacing should check do-while statements #13358

Merged
merged 1 commit into from Jun 13, 2020

Conversation

mdjermanovic
Copy link
Member

@mdjermanovic mdjermanovic commented May 25, 2020

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[X] Bug fix

This bug fix can produce more warnings.

Tell us about your environment

  • ESLint Version: v7.1.0
  • Node Version: v12.14.0
  • npm Version: v6.13.4

What parser (default, Babel-ESLint, etc.) are you using?

default

Please show your full configuration:

Configuration
module.exports = {
  parserOptions: {
      ecmaVersion: 2015
  }
}

What did you do? Please include the actual source code causing the issue.

Online Demo

/* eslint semi-spacing: "error" */

do {
} while(foo) ;

What did you expect to happen?

1 error - unexpected whitespace before semicolon

What actually happened? Please include the actual, raw output from ESLint.

No errors.

What changes did you make? (Give an overview)

Added DoWhileStatement to the list of nodes.

Is there anything you'd like reviewers to focus on?

I searched through the history and couldn't find anything about was this intentionally omitted. I don't think there's another rule that could cause possible conflicts (i.e., another rule that controls these spaces).

@mdjermanovic mdjermanovic added bug ESLint is working incorrectly enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels May 25, 2020
@kaicataldo
Copy link
Member

Agreed that this seems like a semver-minor bug fix.

@kaicataldo kaicataldo added accepted There is consensus among the team that this change meets the criteria for inclusion and removed evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Jun 11, 2020
@kaicataldo kaicataldo merged commit 7686d7f into master Jun 13, 2020
@kaicataldo kaicataldo deleted the semispacing-dowhile branch June 13, 2020 00:35
@kaicataldo
Copy link
Member

Thanks for contributing!

@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Dec 11, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants