Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Improve location for no-mixed-spaces-and-tabs (refs #12334) #13365

Merged
merged 1 commit into from May 31, 2020

Conversation

mdjermanovic
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[X] Other, please explain:

This PR changes reported location in the no-mixed-spaces-and-tabs rule.

What changes did you make? (Give an overview)

The rule used to always report the same column: 1 (0-based), which looks like a bug. Also, it didn't report end loc.

Now, it will report the range of the first space-tab or tab-space pair, so it will underline both the space and the tab.

Before this change:

image

After this change:

image

Is there anything you'd like reviewers to focus on?

@mdjermanovic mdjermanovic added enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules accepted There is consensus among the team that this change meets the criteria for inclusion labels May 26, 2020
Copy link
Member

@yeonjuan yeonjuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@kaicataldo kaicataldo merged commit cb50b69 into master May 31, 2020
@kaicataldo kaicataldo deleted the nomixedspacesandtabs-loc branch May 31, 2020 17:30
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Nov 28, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Nov 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants