Update: Improve location for no-mixed-spaces-and-tabs (refs #12334) #13365
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[X] Other, please explain:
This PR changes reported location in the
no-mixed-spaces-and-tabs
rule.What changes did you make? (Give an overview)
The rule used to always report the same column: 1 (0-based), which looks like a bug. Also, it didn't report
end
loc.Now, it will report the range of the first space-tab or tab-space pair, so it will underline both the space and the tab.
Before this change:
After this change:
Is there anything you'd like reviewers to focus on?