Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: update eslint-config-eslint's required node version #13379

Merged
merged 1 commit into from Jun 11, 2020

Conversation

aladdin-add
Copy link
Member

@aladdin-add aladdin-add commented Jun 1, 2020

it is a breaking change in eslint-config-eslint; tagged Chore to avoid eslint's major release.

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Other, please explain:

What changes did you make? (Give an overview)

as the title.

Is there anything you'd like reviewers to focus on?

atm, the commit format(and release tool) did not consider eslint-config-eslint -- there is a room to improve. :)

it is a breaking change in eslint-config-eslint; tagged `Chore` to avoid eslint's major release.
@aladdin-add aladdin-add added the chore This change is not user-facing label Jun 1, 2020
@kaicataldo
Copy link
Member

atm, the commit format(and release tool) did not consider eslint-config-eslint -- there is a room to improve. :)

Can you clarify what you mean by this?

@aladdin-add
Copy link
Member Author

to eslint-config-eslint, the tag should be breaking. But doing so will make eslint release a major version.

Copy link
Member

@yeonjuan yeonjuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nzakas
Copy link
Member

nzakas commented Jun 11, 2020

I think we also need to manually update the eslint-config-eslint package version with this change?

@kaicataldo
Copy link
Member

I had to figure out how this worked, too. It looks like we have it set up to select the semver release type when kicking off the release (you can see the bot updating the version here), so this should be fine as-is!

@nzakas
Copy link
Member

nzakas commented Jun 11, 2020

Okay cool, then I'll merge this.

@nzakas nzakas merged commit 796f269 into master Jun 11, 2020
@nzakas nzakas deleted the aladdin-add-patch-1 branch June 11, 2020 18:50
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Dec 9, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants