Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: rename id-blacklist to id-denylist (fixes #13407) #13408

Merged
merged 2 commits into from Jun 25, 2020
Merged

Update: rename id-blacklist to id-denylist (fixes #13407) #13408

merged 2 commits into from Jun 25, 2020

Conversation

kaicataldo
Copy link
Member

@kaicataldo kaicataldo commented Jun 10, 2020 •
edited

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[X] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

fixes #13407

What changes did you make? (Give an overview)

This PR renames id-blacklist to id-denylist in a backwards-compatible way. Additionally, this change removes all instances of the term "blacklist" in our code.

As a follow up, we'll probably want to add a redirect on our website for the documentation.

Is there anything you'd like reviewers to focus on?

  1. Note that this word shows up in other projects that we have inlined in our repor for performance testing. Should we change those as well?
  2. Have I missed anything?

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Jun 10, 2020
@kaicataldo kaicataldo added core Relates to ESLint's core APIs and features enhancement This change enhances an existing feature of ESLint evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon labels Jun 10, 2020
@iturgeon iturgeon mentioned this pull request Jun 11, 2020
Merged
mysticatea
mysticatea reviewed Jun 11, 2020
View reviewed changes
lib/rules/index.js Outdated Show resolved Hide resolved
@sarayourfriend sarayourfriend mentioned this pull request Jun 24, 2020
Closed
@kaicataldo
Copy link
Member Author

kaicataldo commented Jun 25, 2020 •
edited

@mysticatea @btmills @nzakas This isn't technically accepted yet - if you support this, would you mind adding a 👍 to my original comment?

Edit: Sorry, just noticed this was officially accepted in the issue! Please ignore.

@kaicataldo kaicataldo self-assigned this Jun 25, 2020
@kaicataldo kaicataldo added accepted There is consensus among the team that this change meets the criteria for inclusion and removed evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Jun 25, 2020
@kaicataldo kaicataldo merged commit 004adae into master Jun 25, 2020
@kaicataldo kaicataldo deleted the remove-blacklist-terminology branch June 25, 2020 17:17
@kaicataldo kaicataldo mentioned this pull request Jun 25, 2020
Merged
@Alhadis
Copy link

Alhadis commented Jul 22, 2020

#BlackListsMatter

@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Dec 23, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Dec 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mysticatea mysticatea mysticatea left review comments

@nzakas nzakas nzakas approved these changes

Assignees

@kaicataldo kaicataldo

Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion core Relates to ESLint's core APIs and features enhancement This change enhances an existing feature of ESLint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove use of blacklist and whitelist
4 participants
@kaicataldo @Alhadis @nzakas @mysticatea