Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: improve report location in arrow-body-style (refs #12334) #13424

Merged
merged 1 commit into from Jun 25, 2020

Conversation

yeonjuan
Copy link
Member

@yeonjuan yeonjuan commented Jun 18, 2020

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain: #12334

What changes did you make? (Give an overview)

Change reporting location loc.start to loc.

Before

  • "always" option

스크린샷 2020-06-19 오전 12 03 36

  • "never" option

스크린샷 2020-06-19 오전 12 03 13

After

  • "always" option

스크린샷 2020-06-19 오전 12 06 29

  • "never" option

스크린샷 2020-06-19 오전 12 05 41

Is there anything you'd like reviewers to focus on?

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Jun 18, 2020
@yeonjuan yeonjuan added accepted There is consensus among the team that this change meets the criteria for inclusion enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules and removed triage An ESLint team member will look at this issue soon labels Jun 18, 2020
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's reasonable to highlight the whole arrow function's body, as it is done in this PR.

LGTM, thanks!

@kaicataldo kaicataldo merged commit 0655f66 into master Jun 25, 2020
@kaicataldo kaicataldo deleted the arrowBodyStyleLoc branch June 25, 2020 18:26
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Dec 23, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Dec 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants