Fix: Replace Infinity with Number.MAX_SAFE_INTEGER (fixes #13427) #13435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nzakas
added
bug
btmills
added
the
patch candidate
btmills
approved these changes
Jun 22, 2020
ljharb
reviewed
Jun 22, 2020
chalkygames123
added a commit
to chalkygames123/front-end-template
that referenced
this pull request
Jun 23, 2020
aladdin-add
added a commit
that referenced
this pull request
Jun 30, 2020
1 task
kaicataldo
pushed a commit
that referenced
this pull request
Jul 3, 2020
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
When cloning a rule's config, if
Infinityis found, it will be replaced withNumber.MAX_SAFE_INTEGER. This should result in the same effective config while preserving serialization.Note: This only fixes the issue introduced in v7.3.0. Configs using
Infinitywill still fail in other areas (like caching and--print-config).We can remove this change once
eslint-config-airbnbupdates their config.Is there anything you'd like reviewers to focus on?