Upgrade: Updated puppeteer version to v4.0.0 #13444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
eslint-deprecated
bot
added
the
triage
Added architecture check to set CHROME_BIN path Signed-off-by: odidev <odidev@puresoftware.com>
kaicataldo
approved these changes
Jun 26, 2020
kaicataldo
added
upgrade
|
@eslint/eslint-team Could we get another pair of eyes on this? |
|
We currently have no such testing environment (aarch64), so it's hard to verify. |
nzakas
approved these changes
Jul 7, 2020
|
Thanks for merging this PR @btmills it will be really helpful if you could make a release with the changes in this PR. |
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[X] Other, please explain:
What changes did you make? (Give an overview)
Updated Puppeteer version to latest in package.json as the latest puppeteer version has support for aarch64 platform and also added architecture check to set
CHROME_BINpath in karma.conf.js.