Fix: Revert config cloning (fixes #13447) #13449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslint-deprecated
bot
added
the
triage
aladdin-add
added
bug
kaicataldo
added
accepted
kaicataldo
approved these changes
Jun 30, 2020
|
To whoever merges this: the commit message should be prefixed with “Fix: “. |
|
@eslint/eslint-tsc Ideally, we would be able to revert this in a semver-patch release. However, since we have some semver-minor commits merged since the last release and don’t have infrastructure set up to backport patches, I think it makes sense to get this into our release on Friday, making sure to call it out in the release notes. |
|
should #12592 be re-opened just to track as it will bring back that issue. |
nzakas
approved these changes
Jul 2, 2020
kaicataldo
changed the title
kaicataldo
changed the title
kaicataldo
changed the title
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
to fix #13447, it reverted #13034 and #13435
After merging this, #12592 need to be reopened.
Is there anything you'd like reviewers to focus on?
no.